Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zigzag parameter table #953

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

awohns
Copy link
Contributor

@awohns awohns commented Jun 1, 2021

During the fix to the population sizes in the ZigZag model (detailed in #745), the parameter table in the docs weren't updated to reflect that the ancient and recent population sizes should be 5x higher

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #953 (8cd7c99) into main (7226245) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          84       84           
  Lines        2728     2728           
  Branches      324      324           
=======================================
  Hits         2709     2709           
  Misses          9        9           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7226245...8cd7c99. Read the comment docs.

Copy link
Contributor

@petrelharp petrelharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! off by 1 isn't a big deal, except it might confuse people in the future...

@petrelharp petrelharp merged commit 26c952e into popsim-consortium:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants