Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anoles Genome #874

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Anoles Genome #874

merged 1 commit into from
Apr 9, 2021

Conversation

Vcaudill
Copy link
Contributor

@Vcaudill Vcaudill commented Apr 8, 2021

will need to update recombination rate
Added mutation rate, population size, and generation time

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Vcaudill. We will need some guess at the recombination rate I think.

stdpopsim/catalog/AnoCar/species.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #874 (8cbb7a0) into main (6aa4ddf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8cbb7a0 differs from pull request most recent head 5f526bd. Consider uploading reports for the commit 5f526bd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
- Coverage   99.40%   99.38%   -0.02%     
==========================================
  Files          77       62      -15     
  Lines        2508     2450      -58     
  Branches      285      285              
==========================================
- Hits         2493     2435      -58     
  Misses          7        7              
  Partials        8        8              
Impacted Files Coverage Δ
stdpopsim/catalog/AnoCar/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/AnoCar/genome_data.py 100.00% <100.00%> (ø)
stdpopsim/catalog/AnoCar/species.py 100.00% <100.00%> (ø)
stdpopsim/catalog/DroMel/species.py 100.00% <0.00%> (ø)
stdpopsim/catalog/StrAga/__init__.py
stdpopsim/catalog/AnaPla/species.py
stdpopsim/catalog/StrAga/genome_data.py
stdpopsim/catalog/AedAeg/species.py
stdpopsim/catalog/HelMel/genome_data.py
stdpopsim/catalog/AedAeg/__init__.py
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa4ddf...5f526bd. Read the comment docs.


# No recombination rate yet for this species.
# Author of BourgeoisEtAl is sending the recombination map
# Recombintation rate of 1e-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need this line - it's redundant with the next one

"LGf": 1e-8,
"LGg": 1e-8,
"LGh": 1e-8,
"MT": 1e-8,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 0

# they mature 8 to 9 months after they are born
# can live up to 8 years in captivity
population_size=5.34e6,
# estimated by using different recombination rates found in BourgeoisEtAl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is not relevant any more, right?

@petrelharp
Copy link
Contributor

LGTM!

lizard genome with temp recmbo rate. Auther from Bourgeois et aal. sending the recombination map. Also fixed generation time (it is 2.5 because they take a year to reach maturity)

Fixed recombination rate to the placeholder rate of 1cM/Mb. Did new population estimates, caculated from theta values

made some edits to make the comments clearer and made the recombination rate fot MT 0
Copy link
Contributor

@petrelharp petrelharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@petrelharp petrelharp merged commit 8367cad into popsim-consortium:main Apr 9, 2021
@petrelharp petrelharp mentioned this pull request Apr 9, 2021
14 tasks
@Vcaudill Vcaudill deleted the anole branch April 9, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants