Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Heliconius melpomene #870

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

percyfal
Copy link
Contributor

@percyfal percyfal commented Apr 8, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #870 (5a35258) into main (93a76db) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5a35258 differs from pull request most recent head d5c5fa6. Consider uploading reports for the commit d5c5fa6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   99.39%   99.39%   -0.01%     
==========================================
  Files          65       65              
  Lines        2464     2460       -4     
  Branches      285      285              
==========================================
- Hits         2449     2445       -4     
  Misses          7        7              
  Partials        8        8              
Impacted Files Coverage Δ
stdpopsim/catalog/HelMel/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/HelMel/genome_data.py 100.00% <100.00%> (ø)
stdpopsim/catalog/HelMel/species.py 100.00% <100.00%> (ø)
stdpopsim/catalog/DroMel/species.py 100.00% <0.00%> (ø)
stdpopsim/catalog/AedAeg/species.py
stdpopsim/catalog/AedAeg/genome_data.py
stdpopsim/catalog/AedAeg/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a76db...d5c5fa6. Read the comment docs.

Copy link
Member

@grahamgower grahamgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @percyfal! Just need to squash the commits with a rebase and this should be good to merge.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grahamgower grahamgower merged commit e6e1c15 into popsim-consortium:main Apr 9, 2021
@grahamgower
Copy link
Member

Great, thanks @percyfal! Would be able to open a QC issue now using the "Species QC" issue template?

@grahamgower grahamgower mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants