Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black in pre-commit. #1224

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

grahamgower
Copy link
Member

Closes #1223.

@grahamgower
Copy link
Member Author

I'm not sure what the process is for developers after this gets merged. Maybe the installed pre-commit sees this change and autoupdates accordingly? In the worst case, something like pre-commit clean && pre-commit install -f might be needed by a developer (but possibly not until they change/add a line that uses the power operator!). @jeromekelleher do you know?

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1224 (94cc1d5) into main (6655f5e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1224   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          98       98           
  Lines        3182     3182           
  Branches      414      414           
=======================================
  Hits         3168     3168           
  Misses          6        6           
  Partials        8        8           
Impacted Files Coverage Δ
stdpopsim/catalog/AraTha/species.py 100.00% <ø> (ø)
stdpopsim/catalog/HomSap/species.py 100.00% <ø> (ø)
stdpopsim/catalog/HomSap/demographic_models.py 100.00% <100.00%> (ø)
stdpopsim/engines.py 100.00% <100.00%> (ø)
stdpopsim/qc/HomSap.py 100.00% <100.00%> (ø)
stdpopsim/slim_engine.py 99.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6655f5e...94cc1d5. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The update is pretty painless I think. I didn't notice any changes when it went through tskit/msprime, so I think it's probably fine to go ahead.

@grahamgower
Copy link
Member Author

Cool, thanks Jerome.

@grahamgower grahamgower merged commit e8e055e into popsim-consortium:main Apr 22, 2022
@grahamgower grahamgower deleted the update-black branch April 22, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update black
2 participants