Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix enum return types and assert for types within tests #1

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix enum return types and assert for types within tests #1

merged 1 commit into from
Oct 18, 2022

Conversation

thetutlage
Copy link
Member

This PR comes with following changes/improvements

  • The return value for enum type now correctly infers from the user defined options.
  • Tests now also asserts for the types.
  • Added license signature to all the files.
  • Added explicit return types to the schema validation functions

@thetutlage thetutlage requested a review from Julien-R44 October 18, 2022 06:34
@Julien-R44
Copy link
Member

Cool thanks!

@Julien-R44 Julien-R44 merged commit cc10cb8 into develop Oct 18, 2022
@Julien-R44 Julien-R44 deleted the small_improvements branch October 18, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julien-R44 Julien-R44 Julien-R44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thetutlage @Julien-R44