Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteComponent not needed as causing issues passing props #60

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

sansjack
Copy link
Contributor

@sansjack sansjack commented Jul 16, 2024

#Since this type changed svelte5 does not need the SvelteComponent as this is was expecting children as a prop and not each props such as class etc.

This should fix the typing and allow us to pass svelte component attributes:

Before:
image

After Requested Change:
image

this may not be the correct approach so please add your two cents!

#59

@poppa poppa merged commit 83710ce into poppa:feature/svelte5 Jul 16, 2024
@poppa
Copy link
Owner

poppa commented Jul 16, 2024

Thanks for your contribution, it's much appreciated 😀

@sansjack
Copy link
Contributor Author

Thanks for your contribution, it's much appreciated 😀

you're more than welcome, thanks for making this!!
i think this needs to be revisited as the typing is not 100% correct... but it works better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants