Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVERT 08ebf90 #191

Closed
wants to merge 1 commit into from
Closed

REVERT 08ebf90 #191

wants to merge 1 commit into from

Conversation

13r0ck
Copy link

@13r0ck 13r0ck commented Nov 14, 2022

This fixes the pang sd card issue

@13r0ck 13r0ck marked this pull request as ready for review November 14, 2022 22:29
@XV-02 XV-02 self-assigned this Nov 15, 2022
@XV-02
Copy link

XV-02 commented Nov 15, 2022

This isn't resolving the core issue of detection on hot-plug. However, it does seem to be having some kind of effect.
Previously:

  • Booting with a micro-SD card present would result in detection and mounting.
  • Hot plugging does not work, regardless of whether a card was present at boot.

With this reversion:

  • Booting with a micro-SD card present results in detection and mounting.
  • Hot plugging works if card was present at boot.
  • Hot plugging does not work if card was not present at boot.

As a note: Bouncing the kernel module related to SD card reading had the same effect - enabling hot plug detection - both with and without this PR.

@13r0ck
Copy link
Author

13r0ck commented Nov 15, 2022

This issue is unrelated to this. Now that we know the issue is micro sd hot plug we need to find the point release that broke it. 5.18 seems broken, 5.13 seems fine. Need to narrow that gap.

@13r0ck 13r0ck closed this Nov 15, 2022
@13r0ck 13r0ck deleted the revert-08ebf90 branch December 14, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants