Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtekal pl join UI er model relation #18

Merged
merged 33 commits into from
Feb 9, 2024

Conversation

rtekal
Copy link
Collaborator

@rtekal rtekal commented Feb 9, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

chriscollins3456 and others added 30 commits February 2, 2024 15:55
)

Co-authored-by: Dimitri GRISARD <dgrisard-externe@bedrockstreaming.com>
Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
…roject#9651)

Co-authored-by: si-chakraborty <si.chakraborty@adevinta.com>
Co-authored-by: Peng Gao <pgao@slack-corp.com>
@rtekal rtekal requested a review from poorvi767 February 9, 2024 17:34
@rtekal rtekal merged commit f2f8023 into poorvi767:pl-join-ui Feb 9, 2024
25 checks passed
props.putAll(
Map.of(
DUHE_SCHEMA_REGISTRY_TOPIC_KEY + SYSTEM_UPDATE_TOPIC_KEY_ID_SUFFIX,
schemaRegistryService.getSchemaIdForTopic(duheTopicName).get().toString(),

Check warning

Code scanning / QDJVMC

Optional.get() is called without isPresent() check Warning

Optional.get() without 'isPresent()' check
DUHE_SCHEMA_REGISTRY_TOPIC_KEY + SYSTEM_UPDATE_TOPIC_KEY_ID_SUFFIX,
schemaRegistryService.getSchemaIdForTopic(duheTopicName).get().toString(),
MCL_VERSIONED_SCHEMA_REGISTRY_TOPIC_KEY + SYSTEM_UPDATE_TOPIC_KEY_ID_SUFFIX,
schemaRegistryService.getSchemaIdForTopic(mclTopicName).get().toString()));

Check warning

Code scanning / QDJVMC

Optional.get() is called without isPresent() check Warning

Optional.get() without 'isPresent()' check
public class SystemUpdateCondition implements Condition {
@Override
public boolean matches(ConditionContext context, AnnotatedTypeMetadata metadata) {
return context.getBeanFactory().getBean(ApplicationArguments.class).getNonOptionArgs().stream()

Check warning

Code scanning / QDJVMC

Nullability and data flow problems Warning

Method invocation getBean may produce NullPointerException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.