This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
forked from sciencemesh/nc-sciencemesh
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com>
Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com>
michielbdejong
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
parhamin2010
pushed a commit
that referenced
this pull request
May 19, 2023
* fix incorrect remote in tne accept share dialog #294 Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> * remove quotes from remote_id #295 Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> * remove unnecessary log --------- Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com>
michielbdejong
added a commit
that referenced
this pull request
Jun 13, 2023
* add API routes, add ApiController * add ApiController.php, add migration for ocm_tokens and ocm_remote_users table, add to migration to info.xml * add API methods (authenticate, addToken, getToken, TokenList), change routes to GET for testing * add API methods (authenticate, addToken, getToken, TokenList), change routes to GET for testing * add new migration for db changes on remote_table & tokens, change API routes for initiator+get and post methods, Change ApiController for set request+ttoken validation+get header values+return proper response * add comments * some modification on apicontroller method for get the params instead of header, modification on one route from post to get, add some modification on database structure * remove initiator from get_token method * remove email param from ocm_remote_user query * Adapt to new invite generation endpoint (draft) * Fix token generation * resolve conflicts on contact.js * Adapt search plugin * TODO: get permissions from inside the protocol * fix token generator url json problem, #287 * add removed } for internal error * Attempt to fix pondersource/sciencemesh-php#189 * Http::STATUS_INTERNAL_SERVER_ERROR * Remove comment * Deal with response from /sciencemesh/accept-invite * Deal with non-URL idp * add provider * fix missing recipientHost in call to /sciencemesh/create-share * params[share]... -> params... * Fix storing of sharedSecret (token) in addSentShare * working on #293 * Fixed reading permissions from the reva incoming request * deal with null accepted users * Mrv/share dialog (#297) * fix incorrect remote in tne accept share dialog #294 Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> * remove quotes from remote_id #295 Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> * remove unnecessary log --------- Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> * get sharedSecret from the right array member * Tag v0.2.0 * Tag v0.3.0 * Built v0.3.0 * info.xml did not validate: The value 'mit' is not an element of the set {'agpl', 'mpl', 'apache'}. * Tag v0.3.1 * Built v0.3.1 * remove: error_logs * remove: whitespace * Fix #300 * Get remote out of URI * Tag v0.4.0 * Build v0.4.0 * Update release.sh * modify: initial use of inheritance for creating share provider class * fix: call parent constructor to avoid breaking nextcloud * modify: class signature to make parent constructor happy! * fix: use statements. * add: parent class stub file which has replaced private with protected. * add: people who had contributed to the project and missing emails * remove: unnecessary use statement * modify: rename file and apply final changes * fix: mixed space and tabs * Add missed use statement * remove error log * add `use OCA\ScienceMesh\AppInfo\ScienceMeshApp;` * fix config key Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com> * add public api annotation Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com> * bugfix and finalization Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com> --------- Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com> Co-authored-by: Parham R <parhamin2010@gmail.com> Co-authored-by: Michiel de Jong <michiel@unhosted.org> Co-authored-by: root <root@cloud.pondersource.org> Co-authored-by: Yashar PourMohammad <yasharpm@gmail.com> Co-authored-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> Co-authored-by: MohammadReza vahedi <mr.vahedi68@gmail.com>
MahdiBaghbani
added a commit
that referenced
this pull request
Jun 23, 2023
* add API routes, add ApiController * add ApiController.php, add migration for ocm_tokens and ocm_remote_users table, add to migration to info.xml * add API methods (authenticate, addToken, getToken, TokenList), change routes to GET for testing * add API methods (authenticate, addToken, getToken, TokenList), change routes to GET for testing * add new migration for db changes on remote_table & tokens, change API routes for initiator+get and post methods, Change ApiController for set request+ttoken validation+get header values+return proper response * add comments * some modification on apicontroller method for get the params instead of header, modification on one route from post to get, add some modification on database structure * remove initiator from get_token method * remove email param from ocm_remote_user query * Adapt to new invite generation endpoint (draft) * Fix token generation * resolve conflicts on contact.js * Adapt search plugin * TODO: get permissions from inside the protocol * fix token generator url json problem, #287 * add removed } for internal error * Attempt to fix pondersource/sciencemesh-php#189 * Http::STATUS_INTERNAL_SERVER_ERROR * Remove comment * Deal with response from /sciencemesh/accept-invite * Deal with non-URL idp * add provider * fix missing recipientHost in call to /sciencemesh/create-share * params[share]... -> params... * Fix storing of sharedSecret (token) in addSentShare * working on #293 * Fixed reading permissions from the reva incoming request * deal with null accepted users * Mrv/share dialog (#297) * fix incorrect remote in tne accept share dialog #294 Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> * remove quotes from remote_id #295 Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> * remove unnecessary log --------- Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> * get sharedSecret from the right array member * Tag v0.2.0 * Tag v0.3.0 * Built v0.3.0 * info.xml did not validate: The value 'mit' is not an element of the set {'agpl', 'mpl', 'apache'}. * Tag v0.3.1 * Built v0.3.1 * remove: error_logs * remove: whitespace * Fix #300 * Get remote out of URI * Tag v0.4.0 * Build v0.4.0 * Update release.sh * modify: initial use of inheritance for creating share provider class * fix: call parent constructor to avoid breaking nextcloud * modify: class signature to make parent constructor happy! * fix: use statements. * add: parent class stub file which has replaced private with protected. * add: people who had contributed to the project and missing emails * remove: unnecessary use statement * modify: rename file and apply final changes * fix: mixed space and tabs * Add missed use statement * remove error log * add `use OCA\ScienceMesh\AppInfo\ScienceMeshApp;` * fix config key Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com> * add public api annotation Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com> * bugfix and finalization Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com> --------- Signed-off-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com> Co-authored-by: Parham R <parhamin2010@gmail.com> Co-authored-by: Michiel de Jong <michiel@unhosted.org> Co-authored-by: root <root@cloud.pondersource.org> Co-authored-by: Yashar PourMohammad <yasharpm@gmail.com> Co-authored-by: MohammadReza vahedi <34796044+mrvahedi68@users.noreply.github.com> Co-authored-by: MohammadReza vahedi <mr.vahedi68@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved: