Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing route fields to data source #23

Merged
merged 7 commits into from
Jan 9, 2025
Merged

add missing route fields to data source #23

merged 7 commits into from
Jan 9, 2025

Conversation

wasaga
Copy link
Collaborator

@wasaga wasaga commented Jan 9, 2025 •
edited
Loading

Fixes https://linear.app/pomerium/issue/ENG-1836/terraform-provider-route-value-conversion-error

also marks some properties that receive defaults on create computed so that the TF won't complain.

@wasaga wasaga requested a review from a team as a code owner January 9, 2025 00:45
@wasaga wasaga requested review from kenjenkins and removed request for a team January 9, 2025 00:45
Base automatically changed from wasaga/use-tftimetypes to main January 9, 2025 21:06
@wasaga wasaga merged commit 0c07f47 into main Jan 9, 2025
3 checks passed
@wasaga wasaga deleted the wasaga/route-data-sources branch January 9, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

@kenjenkins kenjenkins Awaiting requested review from kenjenkins kenjenkins is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wasaga @calebdoxsey