Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add settings resource #10

Merged
merged 7 commits into from
Dec 19, 2024
Merged

add settings resource #10

merged 7 commits into from
Dec 19, 2024

Conversation

@wasaga wasaga requested a review from wrmedford December 13, 2024 00:55
@wasaga wasaga requested review from wrmedford, a team and kenjenkins and removed request for a team December 17, 2024 23:24
Copy link

@kenjenkins kenjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I have just a few small questions.

internal/provider/convert.go Outdated Show resolved Hide resolved
internal/provider/convert.go Outdated Show resolved Hide resolved
internal/provider/help/settings.md Show resolved Hide resolved
@wasaga wasaga merged commit cf1265e into main Dec 19, 2024
2 checks passed
@wasaga wasaga deleted the wasaga/settings branch December 19, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants