-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: updates first batch of reference settings #980
Changes from 1 commit
53b9f62
9a05f1c
32f0fe8
42bda3f
b47fe24
61b2d15
fcb90ff
1b6578f
2208c11
0cb1a2f
0f42127
8103d36
3c7b585
8f7c984
faef415
af617ca
2945d4c
b069ff1
0caf87a
8846653
01adb59
4becaa0
debaa74
be423a3
8d29650
b96a4ed
4ac6cf2
023e29c
2a046ac
edcba6f
d4e5871
3bb654a
3174b0b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -275,7 +275,9 @@ authorize_log_fields: | |
- request-id | ||
- path | ||
- ip | ||
``` | ||
|
||
```yaml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So, this one is configurable in the Console. The original ask here (#912) was to move examples into the Core tab if the setting only has Core examples, right? Again, I may have misunderstood the suggestion. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I see. Yes, that was what I originally wrote in #912, but what do you think about moving all 'Examples' into their corresponding tabs? I think it would be good to keep the page structure consistent between reference pages. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a good point, I'll have to comb through these again but it should be quick. |
||
AUTHORIZE_LOG_FIELDS:request-id,path,ip | ||
``` | ||
|
||
|
@@ -285,13 +287,19 @@ AUTHORIZE_LOG_FIELDS:request-id,path,ip | |
# List all HTTP headers | ||
authorize_log_fields: | ||
- headers | ||
``` | ||
|
||
```yaml | ||
AUTHORIZE_LOG_FIELDS:headers | ||
``` | ||
|
||
```yaml | ||
# List custom HTTP headers | ||
authorize_log_fields: | ||
- headers.cookie | ||
- headers.content-type | ||
``` | ||
|
||
```yaml | ||
AUTHORIZE_LOG_FIELDS:headers.cookie,headers.content-type | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically the environment variable examples aren't YAML, so it feels a little off to use
yaml
syntax highlighting for these.I used
bash
for the environment variable examples on the downstream mTLS settings page, but the difference in the rendered output is pretty subtle (at least in light mode), so it probably doesn't matter too much either way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I actually applied the bash syntax after seeing your example. I think the output pops more. I'll update all these to follow suit.