Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

661 | feat (cli query): improve error handling #673

Merged
merged 3 commits into from
Feb 13, 2022
Merged

661 | feat (cli query): improve error handling #673

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b13137
661 | feat (cli query): improve error handling
arcbjorn Feb 8, 2022
403c435
661 | fix (cli query): checker types
arcbjorn Feb 9, 2022
c9b6bdd
661 | ref (cli query): final error handler
arcbjorn Feb 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cli/src/commands/query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ export default {
print.error("-----------------------------------");
}
}

if (errors) {
process.exitCode = 1;
}
}
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar Feb 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why another condition? We should add this after printing errors

Copy link
Contributor Author

@arcbjorn arcbjorn Feb 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, did some experimenting with types. Fixed now, thank you

}
},
Expand Down