Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for embedded wrappers #1445

Merged
merged 5 commits into from
Dec 16, 2022
Merged

Conversation

nerfZael
Copy link
Contributor

No description provided.

@nerfZael nerfZael marked this pull request as ready for review December 15, 2022 20:49
@@ -0,0 +1,173 @@
import fs from "fs";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these on purpose? i guess they should only live in core-client and they are repeated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are, they test embedded wrappers when added through the PolywrapClient which uses our default config with the config builder

Copy link
Contributor

@dOrgJelli dOrgJelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dOrgJelli dOrgJelli merged commit 17a71cb into origin-dev Dec 16, 2022
@nerfZael nerfZael linked an issue Jan 10, 2023 that may be closed by this pull request
@dOrgJelli dOrgJelli deleted the nerfzael-tests-for-embedded-wrappers branch April 10, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrappers can be embedded into applications
3 participants