Merge pull request #1487 from polywrap/fix/uri-resolver-ext-handle-nu…

…ll-result fix: handle null return values from uri resolver extensions
polywrap · Jan 18, 2023 · 031da0f · 031da0f
2 parents 40eca83 + b08a86e
commit 031da0f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/js/core/src/interfaces/uri-resolver.ts b/packages/js/core/src/interfaces/uri-resolver.ts
@@ -4,8 +4,8 @@ import { Tracer } from "@polywrap/tracing-js";
 import { Result } from "@polywrap/result";
 
 export interface MaybeUriOrManifest {
-  uri?: string;
-  manifest?: Uint8Array;
+  uri?: string | null;
+  manifest?: Uint8Array | null;
 }
 
 export const module = {
@@ -32,8 +32,8 @@ export const module = {
       invoker: Invoker,
       wrapper: Uri,
       path: string
-    ): Promise<Result<Uint8Array | undefined, WrapError>> => {
-      return invoker.invoke<Uint8Array | undefined>({
+    ): Promise<Result<Uint8Array | null, WrapError>> => {
+      return invoker.invoke<Uint8Array | null>({
         uri: wrapper.uri,
         method: "getFile",
         args: {

diff --git a/packages/js/uri-resolver-extensions/src/UriResolverExtensionFileReader.ts b/packages/js/uri-resolver-extensions/src/UriResolverExtensionFileReader.ts
@@ -34,7 +34,7 @@ export class UriResolverExtensionFileReader implements IFileReader {
       path
     );
     if (!result.ok) return result;
-    if (result.value === undefined) {
+    if (!result.value) {
       return ResultErr(new Error(`File not found at ${path}`));
     }
     return {