Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace From<...> for Extension/Attribute with TryFrom<...> for Extension/Attribute #29

Closed
bitfl0wer opened this issue Apr 14, 2024 · 0 comments · Fixed by #30
Closed

Replace From<...> for Extension/Attribute with TryFrom<...> for Extension/Attribute #29

bitfl0wer opened this issue Apr 14, 2024 · 0 comments · Fixed by #30
Assignees
@bitfl0wer

Comments

@bitfl0wer
Copy link
Member

The implementations of From<[CustomType]> for Attribute/Extension can fail if bad data is provided,
crashing the program. It is better to use TryFrom<[CustomType]> for Attribute/Extension, which will
return a Result<[CustomType], Error> instead of panicking.
@bitfl0wer bitfl0wer self-assigned this Apr 14, 2024
@bitfl0wer bitfl0wer mentioned this issue Apr 14, 2024
Merged
bitfl0wer added a commit that referenced this issue Apr 14, 2024
@bitfl0wer
Fix KeyUsage/KeyUsages (#30)
7f84697 
I misread and/or misinterpreted information from RFC5280, describing the KeyUsage extension. This PR properly implements the KeyUsage extension as intended in RFC5280 (closes #28), closes #29, re-exports `der` and `spki` and makes errors a little nicer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitfl0wer bitfl0wer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix KeyUsage/KeyUsages polyphony-chat/polyproto-rs
1 participant
@bitfl0wer