Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: golang.org/x/tools requires go 1.22 #90

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Dec 2, 2024

The PR bumps the go version in go.mod to 1.22 because the package golang.org/x/tools requires Go 1.22.

This was discovered by simply building go-errorlint locally.

❯ git clone https://github.com/polyfloyd/go-errorlint.git
Cloning into 'go-errorlint'...
remote: Enumerating objects: 787, done.
remote: Counting objects: 100% (123/123), done.
remote: Compressing objects: 100% (79/79), done.
remote: Total 787 (delta 75), reused 52 (delta 39), pack-reused 664 (from 1)
Receiving objects: 100% (787/787), 122.00 KiB | 1.56 MiB/s, done.
Resolving deltas: 100% (440/440), done.
❯ cd go-errorlint
❯ go version
go version go1.23.3 darwin/arm64
❯ go build -v
go: updates to go.mod needed; to update it:
        go mod tidy

@polyfloyd
Copy link
Owner

Huh, odd. The CI should have caught that. Thanks

@polyfloyd polyfloyd merged commit 5e56b80 into polyfloyd:main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants