Update version of eth-utils to match requirements #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In polkascan#388 I edited the requirements.txt and didn't notice that the requirements are hardcoded in the setup.py. This PR is to have the same version in both
Yes this would indeed be the way to go, I'll have a look when I'm back in the office |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #388 I edited the requirements.txt and didn't notice that the requirements are hardcoded in the setup.py. This PR is to have the same version in both
py-substrate-interface/requirements.txt
Line 10 in 43ad00c
Would you consider using
pyproject.tomlinstead of setup.py to avoid this errors? Also setup.py is being deprecated afaik.