Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup fixes #28 #43

Merged
merged 24 commits into from
Sep 29, 2023
Merged

Followup fixes #28 #43

merged 24 commits into from
Sep 29, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Sep 26, 2023

Small changes that were omitted from #28 for easier review.

Changes can be seen from the commit history:

  • Update README
  • Align clippy with Polkadot-SDK
  • Use workspace version 1.0
  • Use GPL-3.0 License
  • Update rustfmt and gitignore files
  • Delete empty CHANGELOG file

ggwpez and others added 11 commits September 26, 2023 11:34
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
@ggwpez ggwpez marked this pull request as ready for review September 26, 2023 10:44
edition.workspace = true
license.workspace = true
name = "staging-kusama-runtime"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when/how we decided to call it staging? must have missed that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was when this **** used our crate names to publish his very obvious fraudulent clone of our repo, examples are https://crates.io/crates/xcm and his so-called Dust programming language (curiously, he didn't bother to rename all of the substrate source files from .rs to .ds).

So then we still had to publish our crates, even when crates.io has a clear policy of non-interference as they can't decide on the exact rules for name-squatting. In paritytech/polkadot-sdk#1241, we finally pulled off the band-aid and renamed our crates, mostly by adding a staging- prefix to the names. I commented and said that I didn't quite care what the name was, as long as we really did commit to finally publishing our crates.

"bridges",
]
edition = "2021"
# Format comments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

@bkchr bkchr merged commit bfcabce into main Sep 29, 2023
11 checks passed
@bkchr bkchr deleted the oty-followup branch October 25, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants