Remove all non-seed Head Ambassador members from the Program #422
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
changed the title
ggwpez
changed the title
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
system-parachains/collectives/collectives-polkadot/src/ambassador/migrations.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
…dor/migrations.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
|
It seems this address 16SQKanFTrN18k9UE8EFbtyeSGNFPjRBg8caVhGoUNL8cdh6 (on line 4 on this list) is a fake persona and there's a ref => https://polkadot.polkassembly.io/referenda/1041 to remove this address from the list of collectives. |
That's fine. |
| // The pallet has no nice trait that we could call, so need to use the extrinsic... | ||
| let origin: RuntimeOrigin = RawOrigin::Root.into(); | ||
|
|
||
| let call = pallet_ranked_collective::Call::<Runtime, AmbassadorCollectiveInstance>::remove_member { who: acc.clone().into(), min_rank: 3 }; |
There was a problem hiding this comment.
they also stored within the core fellowship pallet, Member storage map.
to remove from ranked collective you can also use do_remove_member_from_rank, it's pub function.
There was a problem hiding this comment.
@ggwpez can you still do this?
There was a problem hiding this comment.
they also stored within the core fellowship pallet, Member storage map.
We would have to call pallet-core-fellowship::offboard then? I think it requires signed origin. There should only be a handful of HAs be removed by this migration, so we can probably offboard them manually?
Or i can fudge a signed origin, but its a bit hacky.
to remove from ranked collective you can also use do_remove_member_from_rank, it's pub function.
Yes but it does not emit an event.
| @@ -45,6 +45,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| ### Added | |||
|
|
|||
| - Fast promotion tracks for the Fellowship ranks I-III ([polkadot-fellows/runtimes#356](https://github.com/polkadot-fellows/runtimes/pull/356)). | |||
| - Migration to remove all but the 21 first elected Head Ambassador members from the Program ([polkadot-fellows/runtimes#422](https://github.com/polkadot-fellows/runtimes/pull/422)). | |||
There was a problem hiding this comment.
Why? Because we have now an upper maximum? Would be nice to have somewhere documented the reason.
There was a problem hiding this comment.
Yea the original OpenGov referendum stated 21 as upper limit: #264
Just enacting the limit now will result in more than 21 people being in there, hence why i added this migration. I will extend the MR description.
There was a problem hiding this comment.
Why not do this as public referendum?
There was a problem hiding this comment.
We discussed with a few HAs and thought this would be better. Doing public referenda would put us back into the same situation, where a number of simultaneous referenda pass and remove more than necessary (which, TBH, is also fine with me). This solution just reduces the number of referenda and makes the selection criteria clear: first 21.
There was a problem hiding this comment.
Can we not remove them in a batch? But if you discussed this, fine.
There was a problem hiding this comment.
Yeah but it's the same thing, people can put up competing batches and we don't have a system to say "just pick one of these referenda". I am also fine with either solution -- the migration to keep the first 21 or allow free-for-all removal referenda. Either way new people won't be able to join until it's below 21.
There was a problem hiding this comment.
Yea Free-for-all-removals could also work, but then they would probably remove too many.
Without the migration we are in a constant race-condition with other proposals.
|
/merge |
|
Enabled Available commands
For more information see the documentation |
The original OpenGov for the Ambassador Program stated 21 maximal Head Ambassadors. The limit of 21 has now been put in place, but there area already more than 21 in there. This Merge Requests removes everyone that was not among the first 21.
quote:
Change:
Add a migration that executes with the next runtime upgrade and removes everyone from the Ambassador program that is not part of the first 21 elected Head Ambassadors:
Implications