Remove unused Kusama Snowbridge code #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
force-pushed
the
remove-kusama-snowbridge
branch
from
3153569
to
41c60e1
Compare
acatangiu
commented
Aug 5, 2024
Comment on lines
-557
to
-555
| // Ethereum bridge pallets. | ||
| EthereumInboundQueue: snowbridge_pallet_inbound_queue = 80, | ||
| EthereumOutboundQueue: snowbridge_pallet_outbound_queue = 81, | ||
| EthereumBeaconClient: snowbridge_pallet_ethereum_client = 82, | ||
| EthereumSystem: snowbridge_pallet_system = 83, |
There was a problem hiding this comment.
These were never used by anyone so I don't think we need to save their indices, we can safely reuse index 80-83
Kusama does not have Ethereum Snowbridge deployed. This commit removes all that unused code. If we decide to deploy Kusama<>Ethereum bridge, we can bring it back. Signed-off-by: Adrian Catangiu <adrian@parity.io>
acatangiu
force-pushed
the
remove-kusama-snowbridge
branch
from
41c60e1
to
0dce6fb
Compare
5 tasks
bkchr
approved these changes
Aug 12, 2024
bkontur
approved these changes
Aug 13, 2024
Remove unneeded deps from BHK
franciscoaguirre
approved these changes
Aug 13, 2024
joepetrowski
approved these changes
Aug 13, 2024
ggwpez
reviewed
Aug 13, 2024
ggwpez
approved these changes
Aug 13, 2024
…ve-kusama-snowbridge
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit ab0f42d
into
polkadot-fellows:main
46 of 47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kusama does not have Ethereum Snowbridge deployed. This commit removes all that unused code.
If we decide to deploy Kusama<>Ethereum bridge, we can bring it back.