Enable elastic scaling node side feature on Polkadot #340
Conversation
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
| pub struct EnableElasticScalingNodeFeature; | ||
| impl OnRuntimeUpgrade for EnableElasticScalingNodeFeature { | ||
| fn on_runtime_upgrade() -> Weight { | ||
| let _ = Configuration::set_node_feature(RawOrigin::Root.into(), 1, true); |
There was a problem hiding this comment.
Why are we not using the constant?
There was a problem hiding this comment.
It's currently in staging (based on current crate version usage), felt that we don't want to use any of the staging stuff here.
There was a problem hiding this comment.
Hmm - don't we have v7 already in the current release? In any case, seems like we would be using staging stuff anyways, just hiding it by using a magic number? Also I think this can wait for the next polkadot-sdk release, where this should be v7 then.
There was a problem hiding this comment.
That makes sense, but this needs to go in same or before release with core time.
I think the reasoning of doing this as a migration was that it's more of a bugfix than a new feature. Once coretime is enabled on polkadot, if this feature bit is not set, one para that gets scheduled on two cores will brick itself. |
This can already be opened today and ready before Coretime lands on Polkadot. Not really an argument to put this into a runtime upgrade. We have done it here using a runtime upgrade, because the feature was added in the same release AFAIR. However, this is not the case anymore. |
This feature is needed on Polkadot to ensure parachains can still make progress if they have multiple cores assigned. Relay chain support for elastic scaling is implemented but requires bumping
polkadot-runtime-parachainscrate version to at least11.0.0which will happen later.