Deprecate xcm::body::TREASURER_INDEX constant, use standard Treasury varian instead
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Jan 20, 2024
ggwpez
approved these changes
Feb 5, 2024
joepetrowski
approved these changes
Feb 5, 2024
…sury-xcm-body-index
acatangiu
approved these changes
Feb 20, 2024
|
/merge |
fellowship-merge-bot
bot
merged commit cacf8c0
into
polkadot-fellows:main
29 checks passed
|
Enabled Available commands
For more information see the documentation |
Bullrich
pushed a commit
to paritytech-stg/runtimes
that referenced
this pull request
Feb 22, 2024
…ry` varian instead (polkadot-fellows#149) Deprecate the `xcm::body::TREASURER_INDEX` constant and use the standard `Treasury` variant from the `xcm::BodyId` type instead. The custom body index is redundant here since the standard `Treasury` body variant exists. It was overlooked previously, and the index was added by mistake. Removing the index should not affect anything. It's only used as one of the origins that guards permissioned operations for the fellowship treasury instance and asset rate pallet instance, and not used to derive any account ids.
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Mar 7, 2024
…varian instead (#3608) Deprecate the `xcm::body::TREASURER_INDEX` constant and use the standard Treasury variant from the `xcm::BodyId` type instead. To align with the production runtimes: polkadot-fellows/runtimes#149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
xcm::body::TREASURER_INDEXconstant and use the standardTreasuryvariant from thexcm::BodyIdtype instead.The custom body index is redundant here since the standard
Treasurybody variant exists. It was overlooked previously, and the index was added by mistake.Removing the index should not affect anything. It's only used as one of the origins that guards permissioned operations for the fellowship treasury instance and asset rate pallet instance, and not used to derive any account ids.