Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeopleKusama, PeoplePolkadot and Encointer don't have price for parent delivery set up #388

Closed
acatangiu opened this issue Jul 17, 2024 · 2 comments · Fixed by #390
Closed

PeopleKusama, PeoplePolkadot and Encointer don't have price for parent delivery set up #388

acatangiu opened this issue Jul 17, 2024 · 2 comments · Fixed by #390

Comments

@acatangiu
Copy link
Contributor

acatangiu commented Jul 17, 2024 •
edited
Loading

PeopleKusama, PeoplePolkadot and Encointer don't have price for parent delivery set up.

They should.

Originally found by @franciscoaguirre in #380 (comment)
@acatangiu acatangiu mentioned this issue Jul 17, 2024
Merged
@franciscoaguirre
Copy link
Contributor

Seems like this was absolutely unintended since the type is created but not used 😅

@franciscoaguirre franciscoaguirre mentioned this issue Jul 17, 2024
Merged
fellowship-merge-bot bot pushed a commit that referenced this issue Jul 18, 2024
@franciscoaguirre
Add delivery fees to encointer and people chains (#390)
db3ac1a 
Fixes #388.

While working on #380 I
noticed `Encointer`, `PeopleKusama` and `PeoplePolkadot` didn't have
delivery fees setup for UMP.
In most cases, the types were created but not used.
This PR uses them.
@acatangiu
Copy link
Contributor Author

Fixed in #390

fellowship-merge-bot bot pushed a commit that referenced this issue Jul 22, 2024
@franciscoaguirre
Add XcmPaymentApi and DryRunApi to all runtimes (#380)
7723274 
Adds the paritytech/polkadot-sdk#3607 and
paritytech/polkadot-sdk#3872 to all runtimes.
These APIs work together to allow dry running and estimating execution
and delivery fees for XCMs.

This PR doesn't allow querying the price in assets different than the
relay token for asset hubs. Can be done in a following PR.
Also tracking #388
and #389 for future
improvemens.

Old PR was #359, this
one targets main already updated to Polkadot SDK 1.13.

## Dear reviewer

Although there are a lot of changes, the main one is the addition of the
two aforementioned APIs to all relays and system parachains. The rest of
the files are tests, which all have the same format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add delivery fees to encointer and people chains franciscoaguirre/polkadot-runtimes
2 participants
@franciscoaguirre @acatangiu