Add docs to ConvertTransaction and NoTransactionConverter #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub trait ConvertTransaction<E> { | ||
| fn convert_transaction(&self, transaction: ethereum::TransactionV2) -> E; | ||
| } | ||
|
|
||
| /// No fallback transaction converter is available. | ||
| // `NoTransactionConverter` is a non-instantiable type (an enum with no variants), | ||
| // so we are guaranteed at compile time that `NoTransactionConverter` can never be instantiated. | ||
| pub enum NoTransactionConverter {} |
There was a problem hiding this comment.
Can we replace the TransactionConverter with NoTransactionConverter in the template node runtime?
The runtime has implemented the ConvertTransactionRuntimeApi, so there is no need for a fallback function there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #166
It's a legacy type (as a last resort for transaction conversion) that is almost never used. In the future we should probably group them into a
Fallbacktype and assign it a default type value, so that people don't need to care about it.