Add hex-encoded IdProvider #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge master! |
|
@sorpaas a bit of context. The default RandomStringProvider in jsonrpc-pubsub returns a 16 alphanumeric character string as SubscriptionId when calling |
sorpaas
approved these changes
Nov 24, 2020
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* Add hex-encoded IdProvider * Update tests * Merge remote-tracking branch 'upstream/master' into tgmichel-pubsub-idprovider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom
IdProviderthat returns an hex encoded 32 characters long string - prefixed with0x- and use it inSubscriptionManager.This is the format used in Ethereum MainNet for subscription ids.