Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add makefile and improve CI #1354

Merged
merged 9 commits into from
Apr 3, 2024
Merged

chore: add makefile and improve CI #1354

merged 9 commits into from
Apr 3, 2024

Conversation

koushiro
Copy link
Collaborator

@koushiro koushiro commented Mar 23, 2024

  • add makefile
  • using make command in CI
  • add cache into CI to speedup

waiting for #1353 to be merged first

@koushiro koushiro marked this pull request as ready for review March 24, 2024 09:33
@koushiro koushiro requested a review from sorpaas as a code owner March 24, 2024 09:33
@koushiro
Copy link
Collaborator Author

koushiro commented Apr 2, 2024

@boundless-forest PTAL

@boundless-forest
Copy link
Collaborator

Let's handle #1327 first and then refactor the CI workflow to the new version. Because some of the docs ci task will be updated once the doc clean merge. @koushiro

@boundless-forest
Copy link
Collaborator

@koushiro Please resolve the conflict.

@boundless-forest
Copy link
Collaborator

image

Seems to be stuck at this stage.

@koushiro
Copy link
Collaborator Author

koushiro commented Apr 3, 2024

Seems to be stuck at this stage.

It should be an issue about branch protection rules, we need an admin or maintainer to merge this PR
cc @sorpaas

scripts/setup-dev.sh Outdated Show resolved Hide resolved
@koushiro koushiro requested a review from sorpaas April 3, 2024 11:11
@sorpaas sorpaas merged commit 3fdaa3e into master Apr 3, 2024
4 checks passed
@sorpaas sorpaas deleted the improve-ci branch April 3, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants