Check EIP-3607 at transaction validation #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgmichel
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
lgtm, just missing a ts test for this.
An alternative to this would be instantiate CheckEvmTransaction with is_empty result, and make this check be part of validate_in_pool_for. The added benefit of that approach is we do this check when following pallet-ethereum or pallet-evm direct code paths, so sharing behaviour and error handling is ideal.
| // Do not allow transactions for which `tx.sender` has any code deployed. | ||
| // | ||
| // This check should be done on the transaction validation (here) **and** | ||
| // on trnasaction execution, otherwise a contract tx will be included in |
There was a problem hiding this comment.
Suggested change
| // on trnasaction execution, otherwise a contract tx will be included in | |
| // on transaction execution, otherwise a contract tx will be included in |
Closed
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EIP-3607 check should be done on the transaction validation (here) andon transaction execution, otherwise a transaction from a contract key will be included in the mempool and pollute the mempool forever.