Add validator to dispatch precompile #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
reviewed
Apr 18, 2023
boundless-forest
changed the title
ashutoshvarma
pushed a commit
to AstarNetwork/frontier
that referenced
this pull request
May 29, 2023
* Add dispatch filter * Fix clippy * Fix review
ashutoshvarma
pushed a commit
to AstarNetwork/frontier
that referenced
this pull request
Jun 8, 2023
* Add dispatch filter * Fix clippy * Fix review
Closed
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not fully understand why we check the
PaysandDispatchClassbefore dispatching. I guess it's to prevent spam payless dispatch, there seems no need to do that, some basic transaction fee was charged when you invoke the dispatch precompile transaction. But this block dispatch theOperationaltype call.In addition, add a filter to before dispatch to support filtering some call according to different runtimes.