Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

SS58 Address #108

Merged
merged 5 commits into from
Jun 13, 2019
Merged

SS58 Address #108

merged 5 commits into from
Jun 13, 2019

Conversation

JoshOrndorff
Copy link
Contributor

@JoshOrndorff JoshOrndorff added S2-Types and Primatives T2-Page Documentation which should live as a detailed external page labels Jun 12, 2019
@JoshOrndorff
Copy link
Contributor Author

Thanks for the fixes Joe!
I've fixed the last todo item as well.

I wouldn't mind someone checking this for correctness, but I'm confident enough that I'm willing to merge it if nobody has time to dig in. Might not be too hard to fact check by following the links above.

The merge conflict is a silly mistake I keep making because I forget to build before pushing which means the translation stuff doesn't get updated. I'll be able to easily resolve it.

@JoshOrndorff JoshOrndorff changed the title SS58 Address: First Draft SS58 Address Jun 13, 2019
Wish I could make top level things links
@shawntabrizi shawntabrizi merged commit 3acf677 into source Jun 13, 2019
@shawntabrizi shawntabrizi deleted the joshy-ss58 branch June 14, 2019 00:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T2-Page Documentation which should live as a detailed external page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants