Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

compare-with-create-first-update #8

Merged
merged 3 commits into from
Dec 12, 2021
Merged

Conversation

lisa-parity
Copy link
Collaborator

@lisa-parity lisa-parity commented Nov 24, 2021

Update local blockchain tutorial in the sandbox with changes from polkadot-developers/substrate-docs#607

Copy link

@sacha-l sacha-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

One thing: is there a reason to remove "bash" in the command snips? The reason I think we should keep them in is because it'll help when we integrate with web dev.

@lsgunnlsgunn
Copy link

Lol, I removed them because they weren't in your PR branch that I was comparing against.
They aretbeing handled quite right in the mkdocs formatting,. It I haven't had that problem before so I suspect the vanilla theme needs a highlight.js extension.

@lisa-parity lisa-parity merged commit 03f0d30 into main Dec 12, 2021
@lisa-parity lisa-parity deleted the LG/update-local-blockchain branch December 12, 2021 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants