Таразанов Максим, ИТМО, М4139 #27
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| try { | ||
| dao.close(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Define and throw a dedicated exception instead of using a generic one.
| import java.nio.file.Files; | ||
| import java.util.List; | ||
|
|
||
| public class ServerMain { |
There was a problem hiding this comment.
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.
| public class MyService implements Service { | ||
| private MyServer server; | ||
|
|
||
| private ServiceConfig config; |
There was a problem hiding this comment.
Private field 'config' could be made final; it is only initialized in the declaration or constructor.
| import java.nio.file.Files; | ||
| import java.util.List; | ||
|
|
||
| public class ServerMain { |
There was a problem hiding this comment.
A class which only has private constructors should be final
| dao.close(); | ||
| } catch (IOException e) { | ||
| logger.error("IOException in close()->dao.close()"); | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Define and throw a dedicated exception instead of using a generic one.
| super.handleRequest(request, session); | ||
| } catch (Exception e) { | ||
| logger.error("IOException in handleRequest->executorService.execute()"); | ||
| System.out.println(e.getClass()); |
There was a problem hiding this comment.
Replace this use of System.out or System.err by a logger.
|
codeclimate не прошел, 0 баллов |
ghost
closed this
No description provided.