Абрамов Илья ИТМО ФИТиП HW1 #24
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import java.lang.foreign.MemorySegment; | ||
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| public class Service implements ru.vk.itmo.Service { |
| flushThresholdBytes = config.flushThresholdBytes(); | ||
| this.storage = new Storage(config); | ||
|
|
||
| System.out.println(config.basePath()); |
There was a problem hiding this comment.
Replace this use of System.out or System.err by a logger.
| import java.util.List; | ||
| import java.util.concurrent.ExecutionException; | ||
|
|
||
| public class MainServer { |
There was a problem hiding this comment.
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.
| public class Server extends HttpServer { | ||
| public static final String ENTITY_PATH = "/v0/entity"; | ||
| private final Dao<MemorySegment, Entry<MemorySegment>> dao; | ||
| public Server(ServiceConfig config, Dao<MemorySegment, Entry<MemorySegment>> dao) throws IOException { |
There was a problem hiding this comment.
'CTOR_DEF' should be separated from previous statement.
| import ru.vk.itmo.test.abramovilya.dao.table.TableEntry; | ||
|
|
||
|
|
||
| import java.lang.foreign.MemorySegment; |
There was a problem hiding this comment.
'import' has more than 1 empty lines before.
| @@ -0,0 +1,82 @@ | |||
| package ru.vk.itmo.test.abramovilya; | |||
|
|
|||
| import one.nio.http.*; | |||
There was a problem hiding this comment.
Using the '.' form of import should be avoided - one.nio.http..
| @@ -0,0 +1,82 @@ | |||
| package ru.vk.itmo.test.abramovilya; | |||
|
|
|||
| import one.nio.http.*; | |||
There was a problem hiding this comment.
Avoid unused imports such as 'one.nio.http'
| @@ -0,0 +1,82 @@ | |||
| package ru.vk.itmo.test.abramovilya; | |||
|
|
|||
| import one.nio.http.*; | |||
There was a problem hiding this comment.
Avoid unused imports such as 'one.nio.http'
| @@ -0,0 +1,82 @@ | |||
| package ru.vk.itmo.test.abramovilya; | |||
There was a problem hiding this comment.
File does not end with a newline.
| private Server server; | ||
| private final ServiceConfig serviceConfig; | ||
| private Dao<MemorySegment, Entry<MemorySegment>> dao; | ||
| public Service(ServiceConfig serviceConfig) { |
There was a problem hiding this comment.
'CTOR_DEF' should be separated from previous statement.
| import java.util.List; | ||
| import java.util.concurrent.ExecutionException; | ||
|
|
||
| public class MainServer { |
There was a problem hiding this comment.
A class which only has private constructors should be final
| @ServiceFactory(stage = 1) | ||
| public static class Factory implements ServiceFactory.Factory { | ||
| @Override | ||
| public ru.vk.itmo.Service create(ServiceConfig config) { |
There was a problem hiding this comment.
Unnecessary use of fully qualified name 'ru.vk.itmo.Service' due to existing import 'ru.vk.itmo.Service'
| } | ||
|
|
||
| @Override | ||
| public void handleDefault(Request request, HttpSession session) throws IOException { |
There was a problem hiding this comment.
Еще нужно добавить обработку исключений на случай непредвиденных серверных ошибок, чтобы это были 5хх.
| _Тут аллокации тоже почти равномерные, однако выделяется ```byte[]``` внутри one.nio read \ | ||
| Я не думаю, что могу как-то уменьшить там число аллокаций_ | ||
|
|
||
| [put_cpu.png](asprof%2Fput_cpu.png) \ |
There was a problem hiding this comment.
В put профиле видно работу jit-а, в следующих дз предлагаю следить за прогревом jvm, чтобы поиск точки разладки и профилирование происходили на максимально соптимизированном приложении, каким оно и будет в проде.
|
|
||
| #### Результаты работы async-profiler: | ||
| [get_alloc.png](asprof%2Fget_alloc.png) \ | ||
| _Видно, что аллокации распределены более-менее равномерно; вероятно, тут ничего оптимизировать не надо_ |
There was a problem hiding this comment.
"более-менее равномерно" не значит, что оптимально.
Например, можно посмотреть на аллокации, связанные с парсингом запроса и выбором сгенерированного хендлера. В крупных приложениях даже оптимизация на пару процентов может дать существенных прирост производительности.
* Stage 1 * Refactor code * Codeclimate * Codeclimate --------- Co-authored-by: Alexey Shik <58121508+AlexeyShik@users.noreply.github.com>
* Stage 1 * Refactor code * Codeclimate * Codeclimate --------- Co-authored-by: Alexey Shik <58121508+AlexeyShik@users.noreply.github.com>
No description provided.