Супрядкина Дарья ИТМО DWS stage 6 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/ru/vk/itmo/test/dariasupriadkina/Server.java # src/main/java/ru/vk/itmo/test/dariasupriadkina/ServiceIml.java # src/main/java/ru/vk/itmo/test/dariasupriadkina/ServiceImlFactory.java # src/main/java/ru/vk/itmo/test/dariasupriadkina/TestServer.java
# Conflicts: # src/main/java/ru/vk/itmo/test/dariasupriadkina/Server.java # src/main/java/ru/vk/itmo/test/dariasupriadkina/ServiceIml.java # src/main/java/ru/vk/itmo/test/dariasupriadkina/ServiceImlFactory.java # src/main/java/ru/vk/itmo/test/dariasupriadkina/TestServer.java
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
incubos
requested changes
May 2, 2024
src/main/java/ru/vk/itmo/test/dariasupriadkina/EntryChunkUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/vk/itmo/test/dariasupriadkina/SelfRequestHandler.java
Outdated
Show resolved
Hide resolved
| Это решение было принято, чтобы отправлять через `session.write` весь чанк с данными, а не каждую его часть | ||
| (length, crlf, <key>, \n, value) по отдельность. В качестве альтернативы можно как раз отправлять каждую часть через session.write, | ||
| тогда аллокацию ByteArrayBuilder можно избежать, но, так как на профиле локов, фигурирует в основном только метод Session.write, | ||
| вероятно, лишнее использование Session.write может привести к затратам на синхронизацию, отчего в конце концов пострадает latency |
There was a problem hiding this comment.
У нас в сессию пишет один поток, поэтому никакого contention нет и затраты на синхронизацию не изменятся.
incubos
requested changes
May 11, 2024
…range-requests # Conflicts: # src/main/java/ru/vk/itmo/test/dariasupriadkina/Server.java
# Conflicts: # src/main/java/ru/vk/itmo/test/dariasupriadkina/SelfRequestHandler.java # src/main/java/ru/vk/itmo/test/dariasupriadkina/Server.java # src/main/java/ru/vk/itmo/test/dariasupriadkina/ServiceImlFactory.java
incubos
approved these changes
May 19, 2024
| if (!iterator.hasNext()) { | ||
| write(EntryChunkUtils.LAST_BYTES, 0, EntryChunkUtils.LAST_BYTES.length); | ||
| } | ||
| scheduleClose(); |
There was a problem hiding this comment.
Мы могли не всё отправить, но всегда инициируем закрытие сессии, верно?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.