Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage 1, Андрей Чешев, Политех #16
Stage 1, Андрей Чешев, Политех #16
Changes from 8 commits
852ff3a
9cd508f
7a9d72e
dabe8db
069b2c9
ecb61d3
f947df4
602c01e
71d5f45
1fbe9c6
d1ead95
e49e1af
549fb23
121db27
25a35c2
0d076a8
adef3c1
f7a74d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Думаю, не очень хорошо, что конфиг сервиса просочился на уровень сервера. Было бы лучше, если бы сервис разобрал данный конфиг, на его основе сформировал бы конфиги зависимостей и инстанцировал их с этими конфигами
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Методы get,put,delete и createServerConfig являются публичными, хотя этого не требуется. Нужно ужесточить доступность/видимость
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Для всех методов отсутствует обработка исключений от DAO
Что, кстати, будет при выбросе исключения?) Автоматом 500 ответ или, может, отсутствие ответа?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сначала закрывается dao, затем сервер перестаёт слушать порт
Получается, что будет попытка обработать часть запросов уже с закрытым dao
Поэтому, нужно сначала прекратить принимать http запросы, а уже потом закрывать dao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вероятно, здесь будет достаточно HttpServer/Server