-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Link out to BIDS Stats Models docs instead of maintaining our own #378
Conversation
@effigies and @adelavega do y'all have thoughts on this, #375 and #374? |
Do we actually cover everything in here, over there? If so, I think dropping |
I think we do except the outputs section, perhaps we can leave that in? Otherwise LGTM |
Codecov Report
@@ Coverage Diff @@
## dev #378 +/- ##
=======================================
Coverage 64.42% 64.42%
=======================================
Files 23 23
Lines 1816 1816
Branches 343 343
=======================================
Hits 1170 1170
Misses 564 564
Partials 82 82 Continue to review full report at Codecov.
|
@adelavega just getting back to this now. Which outputs section did you mean? Just this sentence? "The output of this level will again be a statistical map for the contrast a_vs_b, but summarized across the whole group." @effigies, sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's all I meant but it doesn't seem very important now. I'm no help w/ the rst/md thing. Otherwise still LGTM |
@Shotgunosine Pushed a fix. Thanks for catching that. |
Failures unrelated. Diagnosing separately. |
We probably don't want to duplicate the stats models documentation in the fintlins docs. Closes #377