Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Link out to BIDS Stats Models docs instead of maintaining our own #378

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

Shotgunosine
Copy link
Collaborator

We probably don't want to duplicate the stats models documentation in the fintlins docs. Closes #377

@Shotgunosine
Copy link
Collaborator Author

@effigies and @adelavega do y'all have thoughts on this, #375 and #374?

@effigies
Copy link
Collaborator

Do we actually cover everything in here, over there? If so, I think dropping model.rst altogether in favor of consistently linking to https://bids-standard.github.io/stats-models makes sense.

@adelavega
Copy link
Collaborator

I think we do except the outputs section, perhaps we can leave that in? Otherwise LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #378 (47265dd) into dev (372e6d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #378   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files          23       23           
  Lines        1816     1816           
  Branches      343      343           
=======================================
  Hits         1170     1170           
  Misses        564      564           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372e6d2...47265dd. Read the comment docs.

@Shotgunosine
Copy link
Collaborator Author

@adelavega just getting back to this now. Which outputs section did you mean? Just this sentence? "The output of this level will again be a statistical map for the contrast a_vs_b, but summarized across the whole group."

@effigies, sounds good.

Copy link
Collaborator Author

@Shotgunosine Shotgunosine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but switching from changes.rst to changes.md means that all of the version numbers get included in the toctree. I haven't been able to find a way to stop this
Screen Shot 2022-07-28 at 12 35 16 PM
.

@adelavega
Copy link
Collaborator

I think that's all I meant but it doesn't seem very important now. I'm no help w/ the rst/md thing.

Otherwise still LGTM

@effigies
Copy link
Collaborator

@Shotgunosine Pushed a fix. Thanks for catching that.

@effigies effigies changed the title strip down the statsmodel section DOC: Link out to BIDS Stats Models docs instead of maintaining our own Jul 28, 2022
@effigies
Copy link
Collaborator

Failures unrelated. Diagnosing separately.

@effigies effigies merged commit efd85cb into poldracklab:dev Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fitlins should point to https://bids-standard.github.io/stats-models/
4 participants