Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: modify path patterns to make task optional #275

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

adelavega
Copy link
Collaborator

It should not be required to specify a task in a model (i.e. run a model across all tasks)

I modified the PATH_PATTERNS to make task optional.

Need to test a bit more.

@effigies effigies merged commit 1c8b3f2 into poldracklab:master Jan 21, 2021
@effigies
Copy link
Collaborator

Gah. Failed to read all the way to the bottom. Hope your tests went well.

@adelavega
Copy link
Collaborator Author

Oops. I guess you have no objection in principle. I'll put WIP in the title next time. Tests still running.

@adelavega
Copy link
Collaborator Author

That worked for me, now testing again a use case w/ a task.

By the way, the group level files will look something like this with no task:

space-MNI152NLin2009cAsym_contrast-rms_stat-effect_statmap.nii.gz

A bit ugly but I guess that's bids compliant?

@effigies
Copy link
Collaborator

Yup.

@adelavega
Copy link
Collaborator Author

Okay, yup. For the record this didn't cause any problems for models w/ task for me

@effigies
Copy link
Collaborator

Yeah, it shouldn't have, since the only issue might be change in fallback behavior, and we're not sending multiple patterns to the same nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants