fix: Locked redis package version to 4.0.6 INT-1038 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penwoodjon
changed the title
sarus
requested changes
Jun 6, 2023
There was a problem hiding this comment.
@penwoodjon I don't believe this fixes the issue as the latest Redis library is not compatible with Node12. See this thread:
This PR will allow the integration to start but it just punts the error to when the search is run (and the client is created). When I tried this PR I still get the error:
/polarity-server/integrations/redis/node_modules/redis/dist/index.js:42
...options?.modules
SyntaxError: Unexpected token '.'
I just tested and we can fix the issue by just locking the redis package version to 4.0.6 for now and then revert your changes (i.e., go back to using require at the top of the file).
penwoodjon
changed the title
sarus
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.