Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/daheige/default auth adjust #411

Merged
merged 2 commits into from
Jun 4, 2022
Merged

Feature/daheige/default auth adjust #411

merged 2 commits into from
Jun 4, 2022

Conversation

daheige
Copy link
Member

@daheige daheige commented Jun 4, 2022 •
edited
Loading

Please provide issue(s) of this PR:
feature ##412

  1. go style adjustments
  2. real go code adjustments
  3. utils checkName and checkEmail func code adjust
  4. parseStrategySearchArgs func resTypeFilter and principalTypeFilter logic code adjust
  5. resourceDeduplication func adjust

andrewshan
andrewshan approved these changes Jun 4, 2022
View reviewed changes
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit 8a08a12 into polarismesh:main Jun 4, 2022
@chuntaojun chuntaojun linked an issue Jun 7, 2022 that may be closed by this pull request
Real go code adjustments #412
Closed
daheige pushed a commit to daheige/polaris that referenced this pull request Jun 7, 2022
@andrewshan @daheige
Merge pull request polarismesh#411 from daheige/feature/daheige/defau…
b8d2434 
…lt-auth-adjust

Feature/daheige/default auth adjust
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuntaojun chuntaojun chuntaojun approved these changes

@andrewshan andrewshan andrewshan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Real go code adjustments
3 participants
@daheige @chuntaojun @andrewshan