Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use pak's sys reqs installation #484

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Nov 9, 2023

Recent versions of pak install system dependencies by default, so setting CI: false was meaningless. (See r-lib/rig#184)
And, installing system dependencies by pak does not seem to cause any harm, so we can leave the default settings to simplify configuration.

Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eitsupi eitsupi merged commit 9b1df9c into pola-rs:main Nov 9, 2023
19 checks passed
@eitsupi eitsupi deleted the ci-pak branch November 9, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants