-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow "R source package with Rust library binary" installation #450
Conversation
I must admit I'm a bit lost on the changes in CI and in the procedure to build/install |
Definitely. I was imagining something like |
After merging this, builds on R-universe should use the pre-built binaries and SIMD should be enabled even when installing from R-universe. |
if [ -z "${NOT_CRAN}" ] && [ -n "${MY_UNIVERSE}" ]; then | ||
echo "It seems that this is on R-universe <${MY_UNIVERSE}>." | ||
echo "Trying to download pre-built binary." | ||
LIBR_POLARS_BUILD="false" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step detects R-universe and enable install with pre-built binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've no clue about this, so just merge whenever you think it's ready
Close #408
Allows us to download binaries from GitHub Releases and skip the
cargo build
step using the mechanism copied fromprqlr
.Like this: