Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 0.8.0 #370

Merged
merged 2 commits into from
Sep 3, 2023
Merged

release 0.8.0 #370

merged 2 commits into from
Sep 3, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Sep 2, 2023 •
edited by etiennebacher
Loading

@etiennebacher I think we have it all now for 0.8.0 release

@eitsupi I'm always unsure on correct of order releasing. Is this correct?

  • Make release_0.8.0 branch, Done.
  • use_this::use_version("minor") (0.8.0) + commit, Done
  • Then click on release tap and create a release with release notes, release here , Done
  • use_this::use_version("dev") (0.8.0.9000) + commit
  • merge release_0.8.0 via this PR

Close #364

@sorhawell sorhawell marked this pull request as draft September 2, 2023 22:16
@eitsupi
Copy link
Collaborator

eitsupi commented Sep 3, 2023

@eitsupi I'm always unsure on correct of order releasing. Is this correct?

  • Make release_0.8.0 branch, Done.
  • use_this::use_version("minor") (0.8.0) + commit, Done
  • Then click on release tap and create a release with release notes, release here , Done
  • use_this::use_version("dev") (0.8.0.9000) + commit
  • merge release_0.8.0 via this PR

I think it's good, but the name of the tag is probably v0.8.0?
(If we submit to CRAN, we need to decide which commit to tag depending on CRAN's review, but if we don't submit to CRAN, I think we don't need to go through RC versions.)

@sorhawell sorhawell changed the title WIP: release 0.8.0 release 0.8.0 Sep 3, 2023
@sorhawell sorhawell marked this pull request as ready for review September 3, 2023 12:27
eitsupi
eitsupi approved these changes Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sorhawell sorhawell merged commit 54c1b29 into main Sep 3, 2023
10 checks passed
@sorhawell sorhawell deleted the release_0.8.0 branch September 3, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release polars v0.8.0
2 participants
@sorhawell @eitsupi