fix: add -z noexecstack in Makevars (#1212)

pola-rs · Aug 30, 2024 · 5ccab18 · 5ccab18
1 parent cf0f9e0
commit 5ccab18
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 9 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -118,5 +118,5 @@ Collate:
     'zzz.R'
 Config/rextendr/version: 0.3.1
 VignetteBuilder: knitr
-Config/polars/LibVersion: 0.42.0
+Config/polars/LibVersion: 0.42.1
 Config/polars/RustToolchainVersion: nightly-2024-07-26
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,10 @@
 # NEWS
 
+## Polars R Package (development version)
+
+- Add the option `-z noexecstack` for compilation on Linux to avoid the error
+  `version GLIBC_2.39' not found` (#1212).
+
 ## Polars R Package 0.19.0
 
 ### Breaking changes

diff --git a/configure b/configure
@@ -10,8 +10,12 @@ LIBNAME="libr_polars.a"
 LIBR_POLARS_DEFAULT_PATH="$(pwd)/tools/${LIBNAME}"
 LIBR_POLARS_PATH=${LIBR_POLARS_PATH:-${LIBR_POLARS_DEFAULT_PATH}}
 
+# -z noexecstack added to avoid following error on Ubuntu:
+# /usr/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /usr/local/lib/R/site-library/polars/libs/polars.so)`
+# https://stackoverflow.com/questions/73435637/how-can-i-fix-usr-bin-ld-warning-trap-o-missing-note-gnu-stack-section-imp/73468271#73468271
+#
 # not used on macOS
-ADDITIONAL_PKG_LIBS_FLAG="-lrt"
+ADDITIONAL_PKG_LIBS_FLAG="-lrt -z noexecstack"
 
 export PATH="$PATH:$HOME/.cargo/bin"
 

diff --git a/src/rust/Cargo.toml b/src/rust/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "r-polars"
-version = "0.42.0"
+version = "0.42.1"
 edition = "2021"
 rust-version = "1.80.0"
 publish = false

diff --git a/tools/lib-sums.tsv b/tools/lib-sums.tsv