Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check output in doctest #2306

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

zundertj
Copy link
Collaborator

@zundertj zundertj commented Jan 7, 2022

Will still verify that code does not error.

Will still verify that code does not error.
@github-actions github-actions bot added the python Related to Python Polars label Jan 7, 2022
@ritchie46
Copy link
Member

For context. The maintenance burden is quite high because when we change formatting of the tables we need to update the outputs. There is definitely value to checking the docs, but it would be great if we could overwrite the existing outputs with the expected ones like discussed here: Erotemic/xdoctest#69

For now its turned of until we improved float formatting and table size inference.

@ritchie46 ritchie46 merged commit cd06191 into pola-rs:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants