chore: Move rolling_sum cast for small integer types to logical plan #21421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
requested review from
ritchie46,
orlp,
c-peters and
MarcoGorelli
as code owners
github-actions
bot
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21421 +/- ##
=======================================
Coverage 79.96% 79.97%
=======================================
Files 1597 1597
Lines 229115 229120 +5
Branches 2618 2618
=======================================
+ Hits 183222 183236 +14
+ Misses 45294 45285 -9
Partials 599 599 ☔ View full report in Codecov by Sentry. |
|
This is still at the "implementation" level. I think it should be here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the cast to the logical plan per suggestion by @wence: #21397 (comment)