Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Kahan summation for rolling sum kernels. Fix numerical stability issues #21413

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

ritchie46
Copy link
Member

fixes #11146
fixes #21358

@MarcoGorelli know of any more issues this will close?

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 23, 2025
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 97.84946% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.97%. Comparing base (f5d71bd) to head (0056a22).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...lars-arrow/src/legacy/kernels/rolling/nulls/sum.rs 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21413      +/-   ##
==========================================
+ Coverage   79.89%   79.97%   +0.07%     
==========================================
  Files        1597     1597              
  Lines      229026   229106      +80     
  Branches     2618     2618              
==========================================
+ Hits       182985   183219     +234     
+ Misses      45442    45288     -154     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

The uncompressed lib size after this PR is 41.6033 MB.

@ritchie46 ritchie46 merged commit 7f8adfe into main Feb 23, 2025
25 of 26 checks passed
@ritchie46 ritchie46 deleted the kahan branch February 23, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
1 participant