fix: Method dt.ordinal_day was returning UTC results as opposed to those on the local timestamp
#21410
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
dt.ordinal_day was returning UTC results as opposed to those on the local timestampdt.ordinal_day was returning UTC results as opposed to those on the local timestamp
github-actions
bot
added
fix
…n the local timestamp
MarcoGorelli
force-pushed
the
ordinal-day-tz-aware
branch
from
9bb8b1b to
36f390d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21410 +/- ##
==========================================
- Coverage 79.96% 79.89% -0.07%
==========================================
Files 1597 1597
Lines 229026 229035 +9
Branches 2618 2618
==========================================
- Hits 183133 182991 -142
- Misses 45294 45445 +151
Partials 599 599 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
ritchie46
reviewed
Feb 23, 2025
| .expect("Removing time zone is infallible"); | ||
| ca_local.apply_kernel_cast::<Int16Type>(&f) | ||
| }, | ||
| _ => ca.apply_kernel_cast::<Int16Type>(&f), |
There was a problem hiding this comment.
Can we assign ca from the match statement?
Then we only have to apply &f once, saving some compiler bloat.
There was a problem hiding this comment.
Will already merge so it's included in release. Could you make a follow up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21406