Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Fix pathologic rolling + group-by performance and memory explosion #21403

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

ritchie46
Copy link
Member

fixes #18525

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Feb 22, 2025
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 96.55172% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (237b506) to head (741e66d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../polars-arrow/src/legacy/kernels/sort_partition.rs 89.47% 4 Missing ⚠️
...olars-mem-engine/src/executors/group_by_rolling.rs 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21403      +/-   ##
==========================================
- Coverage   79.95%   79.89%   -0.07%     
==========================================
  Files        1597     1597              
  Lines      228954   229027      +73     
  Branches     2618     2618              
==========================================
- Hits       183069   182981      -88     
- Misses      45286    45447     +161     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

The uncompressed lib size after this PR is 41.6219 MB.

@ritchie46 ritchie46 merged commit ad7fdf1 into main Feb 22, 2025
25 of 26 checks passed
@ritchie46 ritchie46 deleted the rolling branch February 22, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Severe memory issues with rolling and group_by
1 participant