Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Rename credentials parameter to credential in CredentialProviderAzure #21295

Merged
merged 1 commit into from
Feb 17, 2025
Merged

feat(python): Rename credentials parameter to credential in CredentialProviderAzure #21295

merged 1 commit into from
Feb 17, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Feb 17, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (5e51218) to head (27259ad).
Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
.../polars/io/cloud/credential_provider/_providers.py 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #21295      +/-   ##
==========================================
+ Coverage   79.82%   79.90%   +0.07%     
==========================================
  Files        1596     1596              
  Lines      228565   228565              
  Branches     2608     2608              
==========================================
+ Hits       182462   182624     +162     
+ Misses      45507    45345     -162     
  Partials      596      596

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review February 17, 2025 08:31
@ritchie46 ritchie46 merged commit 0c049c3 into pola-rs:main Feb 17, 2025
16 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees

@nameexhaustion nameexhaustion

Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nameexhaustion @ritchie46 @c-peters