fix: Method dt.offset_by
was discarding month and year info if day was included in offset for timezone-aware columns
#21291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21283
Previously, the logic was:
let mut new_t = t
new_t
new_t
The issue was that for the last step, it was starting the calculation from
t
rather than fromnew_t
, which is why the linked issue reports that if'd'
is included, thenyears
andmonths
get discardedI don't think
new_t
is necessary at all -t
can just get incremented at each step, so like this there's no risk of accidentally incrementing the wrong variable